Skip to content

Fix, clean batch metrics on pipeline shutdown#18515

Merged
andsel merged 3 commits intoelastic:mainfrom
andsel:fix/clean_batch_metrics_on_pipeline_relead
Dec 19, 2025
Merged

Fix, clean batch metrics on pipeline shutdown#18515
andsel merged 3 commits intoelastic:mainfrom
andsel:fix/clean_batch_metrics_on_pipeline_relead

Conversation

@andsel
Copy link
Contributor

@andsel andsel commented Dec 18, 2025

Release notes

Cleanup batch statistic metric when a pipeline is shutdown.

What does this PR do?

Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.

Why is it important/What is the impact to the user?

As a user I want that batch metrics doesn't get polluted during pipeline restarts.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Follow the steps documented in the originating #18512

Related issues

@andsel andsel self-assigned this Dec 18, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /run exhaustive tests : Run the exhaustive tests Buildkite pipeline.
@mergify
Copy link
Contributor

mergify bot commented Dec 18, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label
@andsel andsel added the bug label Dec 18, 2025
@andsel andsel marked this pull request as ready for review December 18, 2025 17:16
@andsel andsel changed the title Fix/clean batch metrics on pipeline relead Dec 18, 2025
@elasticmachine
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @andsel

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 1be3a35 into elastic:main Dec 19, 2025
12 checks passed
@andsel
Copy link
Contributor Author

andsel commented Dec 19, 2025

@mergify backport 9.2 9.3

@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2025

backport 9.2 9.3

✅ Backports have been created

Details
mergify bot pushed a commit that referenced this pull request Dec 19, 2025
Cleanup batch statistic metric when a pipeline is shutdown.

Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.

(cherry picked from commit 1be3a35)
mergify bot pushed a commit that referenced this pull request Dec 19, 2025
Cleanup batch statistic metric when a pipeline is shutdown.

Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.

(cherry picked from commit 1be3a35)
andsel added a commit that referenced this pull request Dec 23, 2025
…#18520)

Cleanup batch statistic metric when a pipeline is shutdown.

Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.

(cherry picked from commit 1be3a35)

Co-authored-by: Andrea Selva <selva.andre@gmail.com>
andsel added a commit that referenced this pull request Dec 29, 2025
Cleanup batch statistic metric when a pipeline is shutdown.

Adds a test to verify that pipeline's shutdown (used during pipeline reload) clear the batch metrics, this is done in JavaPipeline#clear_pipeline_metrics method.

(cherry picked from commit 1be3a35)

Co-authored-by: Andrea Selva <selva.andre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants