Publish distribution image to DockerHub as package-registry-distribution

[teresaromero]

Summary

• Retag the internal docker.elastic.co/package-registry/distribution image as package-registry/package-registry-distribution (same digest) so it can be published under a non-misleading name.
• Update the DockerHub copy step to publish as elastic/package-registry-distribution instead of elastic/distribution.

Related issue

Related to elastic/platform-engineering-productivity#2953, which tracks deleting the old elastic/distribution image from DockerHub once this is live.

Follow-up of #1692, which added the DockerHub copy step and introduced the elastic/distribution name.

[mrodm]

Looking at the previous step, the script manages the case of the environment variable DRY_RUN being true to skip the publication.

Here we should do the same to keep consistency.

What about adding this ?

DRY_RUN="$$(buildkite-agent meta-data get DRY_RUN --default="${DRY_RUN:-"false"}")"
if [[ "$${DRY_RUN:-"false"} == "true" ]]; then
    echo "Skip triggering steps to release images to Docker Hub"
    exit 0
fi

In case we want to trigger this step from the UI in DRY_RUN true mode.

[mrodm]

Maybe this could be moved to another pull request.

what I'm thinking is to add another input item

  - input: ":truffleruby: Input version for docker tag"
    key: input
    if: "build.source == 'ui'"
    fields:
      - text: "The docker tag to be published (format: major.minor.patch(-prerelease)?)."
        hint: "e.g. 0.0.1"
        key: "DOCKER_TAG"
        required: true
      - text: "DRY_RUN."
        key: DRY_RUN
        options:
          - label: "True"
            value: "true"
          - label: "False"
            value: "false"
        default: "true"

Then remove the hard-coded value for DRY_RUN from the env key in the pipeline definition:

package-registry/.buildkite/release-package-registry-distribution.yml

Line 40 in 3f85ee1

DRY_RUN: false

And update the script for that to include the retrieval of that variable

DRY_RUN="$(buildkite-agent meta-data get DRY_RUN --default="${DRY_RUN:-"false"}")"
if [[ "${DRY_RUN:-"false"} == "true" ]]; then
    echo "Skip triggering steps to release images to Docker Hub"
    exit 0
fi

So, if the pipeline is triggered from another pipeline (using a trigger step) by default DRY_RUN will get the value false if not defined.

When triggered using the UI, by default will be true this variable (from the input step). Values filled from the input step are retrieved from the meta-data.

[teresaromero]

i've added the DRY_RUN guard, i think the other should be part of a dedicated PR as a followup improvement

[teresaromero]

followup #1809

[infra-vault-gh-plugin-prod]

💚 Build Succeeded

• Buildkite Build
• Commit: 76b2d84

History

• 💚 Build #2182 succeeded 404dea6
• 💚 Build #2181 succeeded cd48af8

[mrodm]

🚀

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request