Skip to content
This repository was archived by the owner on Jan 27, 2023. It is now read-only.

Add barracuda/0.1.0 integration (snapshot) - #152

Merged
adriansr merged 5 commits into
elastic:snapshotfrom
adriansr:rsa2elk_barracuda_snapshot
Jul 30, 2020
Merged

Add barracuda/0.1.0 integration (snapshot)#152
adriansr merged 5 commits into
elastic:snapshotfrom
adriansr:rsa2elk_barracuda_snapshot

Conversation

@adriansr

@adriansr adriansr commented Jul 22, 2020

Copy link
Copy Markdown

This adds the first rsa2elk integration package for Barracuda WAF devices.

After this one, I'll add the next 19 rsa2elk devices in a single PR if possible. They all follow the exact same structure than this one.

Screenshots

Screenshot 2020-07-23 at 15 41 58

Screenshot 2020-07-23 at 15 42 38

With logo:

Screenshot 2020-07-28 at 12 02 13

@adriansr
adriansr requested review from a team and ycombinator July 22, 2020 16:57
@elasticmachine

elasticmachine commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-28T16:39:40.015+0000

  • Duration: 9 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

@mtojek mtojek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall effect looks good, only some nit-picks. Did you try to run this one and see the results in the UI? We used to publish a screenshot from Kibana UI to present the configuration form.

After this one, I'll add the next 19 rsa2elk devices in a single PR if possible. They all follow the exact same structure than this one.

It's fine, you can combine these integrations together.

keep_raw: {{keep_raw_fields}}
debug: {{debug}}
source: |
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchaulet @michalpristas Could you please confirm that such huge blobs should be supported by all parties?

Comment thread packages/barracuda/0.1.0/dataset/waf/manifest.yml Outdated
Comment thread packages/barracuda/0.1.0/manifest.yml Outdated
title: Collect logs from Barracuda Web Application Firewall via file
description: Collecting syslog from Barracuda Web Application Firewall via file.
# No icon
icon:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we can easily find a barracuda svg to dump on here, is there a reason not to add an icon?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik we don't have (yet) clearance from Barracuda for the use of their logo in a commercial product. I see a lot of logos in other packages, @mtojek is someone from the ingest manager team handling this? /cc @jamiehynds

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody. Currently used logos are imported from existing open-source repos of Elastic. In general in terms of the ingest manager, the point of contact is @ruflin .

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I pulled the logo from https://www.elastic.co/integrations for my WIP integration. Even though I once went to law school, IANAL, so not entirely sure what additional consent we need from those other companies for inclusion of their logos here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @jamiehynds we're OK adding the logos. Will update the PR.

Comment thread packages/barracuda/0.1.0/docs/README.md
Comment thread packages/barracuda/0.1.0/dataset/waf/agent/stream/udp.yml.hbs Outdated
@adriansr

Copy link
Copy Markdown
Author
  • Changed categorization to Network + Security
  • Added logo:

Screenshot 2020-07-28 at 12 02 13

@mtojek
mtojek self-requested a review July 29, 2020 09:31
@adriansr
adriansr merged commit 850e911 into elastic:snapshot Jul 30, 2020
thomasneirynck pushed a commit to thomasneirynck/package-storage that referenced this pull request Sep 28, 2021
This adds the yamlpipeline package with 3 ingest pipelines in yaml.

Closes elastic/package-registry#150
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants