Skip to content

Adding Azure Blob Storage output support - #47

Merged
P1llus merged 9 commits into
elastic:mainfrom
P1llus:azure_blob_storage
Jan 17, 2023
Merged

Adding Azure Blob Storage output support#47
P1llus merged 9 commits into
elastic:mainfrom
P1llus:azure_blob_storage

Conversation

@P1llus

@P1llus P1llus commented Nov 23, 2022

Copy link
Copy Markdown
Member

This PR adds support for Azure Blob Storage output, for adding system tests on integrations.

@elasticmachine

elasticmachine commented Nov 23, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-17T11:05:58.191+0000

  • Duration: 5 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus
P1llus requested a review from andrewkroh November 24, 2022 10:57
@andrewkroh
andrewkroh requested a review from ShourieG December 6, 2022 13:43
@andrewkroh

Copy link
Copy Markdown
Contributor

@ShourieG Can you please review this since you are familiar with the Azure SDK.

@ShourieG

Copy link
Copy Markdown

@P1llus one question, do you feel it's worth while to test output for all 3 types of blobs ? Block, append & page types? Currently we are only checking for block blobs I think.

@ShourieG

Copy link
Copy Markdown

@P1llus Approving the PR for now, but we can enhance it later with support for other types of blobs.

Comment thread pkg/output/options.go Outdated
WebhookOptions
GCPPubsubOptions
KafkaOptions
ABSOptions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a more verbose name like AzureBlobStorageOptions.

@P1llus

P1llus commented Jan 17, 2023

Copy link
Copy Markdown
Member Author

@P1llus one question, do you feel it's worth while to test output for all 3 types of blobs ? Block, append & page types? Currently we are only checking for block blobs I think.

I think we could most likely add more support later for sure, I will leave a note for it, however we would need to merge this at some point to get the integration package up

@P1llus
P1llus merged commit d35c829 into elastic:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants