Skip to content

fix: deduplicate publish tasks by value - #10134

Open
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/deduplicate-publish-tasks
Open

fix: deduplicate publish tasks by value#10134
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/deduplicate-publish-tasks

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

  • deduplicate uploads by file path and architecture
  • preserve distinct architecture uploads for the same artifact path
  • add a focused regression test

Why

new Set(uploadOptions) compares option objects by identity, so equivalent objects were never removed. Repeated CLI files or programmatic upload entries could therefore publish the same artifact more than once.

Tests

  • TEST_FILES=publishCliTest corepack pnpm ci:test
  • corepack pnpm compile
  • corepack pnpm ci:validate
  • targeted ESLint
  • git diff --check

Breaking changes

Duplicate entries for the same file and architecture now produce one upload, matching the existing deduplication intent.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ebc6c48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant