Skip to content

fix: resolve retina backgrounds by terminal extension - #10143

Open
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/resolve-retina-background-extension
Open

fix: resolve retina backgrounds by terminal extension#10143
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/resolve-retina-background-extension

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

  • derive @2x background names from the actual terminal extension
  • preserve uppercase and mixed-case extensions
  • avoid treating extensionless source files as their own retina companion
  • add focused regressions

Why

The lowercase-only replacement did not change .PNG and extensionless paths. If the original file existed, it was then incorrectly passed to tiffutil as both the base and retina image.

Tests

  • TEST_FILES=mac/dmgBackgroundTest corepack pnpm ci:test
  • corepack pnpm compile
  • corepack pnpm ci:validate
  • git diff --check

Breaking changes

None.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3e5b981

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant