Skip to content

refactor: replace deprecated recursive rmdir - #10146

Open
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/replace-recursive-rmdir
Open

refactor: replace deprecated recursive rmdir#10146
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/replace-recursive-rmdir

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

  • replace deprecated recursive fs.rmdir usage with fs.rm
  • preserve the existing custom-toolset cache cleanup behavior

Why

Recursive rmdir has been deprecated in Node for years. The repository requires Node 22+, where rm({ recursive: true }) is the supported equivalent.

Tests

  • TEST_FILES=customToolsetTest corepack pnpm ci:test
  • corepack pnpm compile
  • corepack pnpm ci:validate
  • git diff --check

Breaking changes

None.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 97a6e3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant