Skip to content

fix: clean up publish SIGINT listeners - #10147

Open
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/cleanup-publish-sigint-listener
Open

fix: clean up publish SIGINT listeners#10147
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/cleanup-publish-sigint-listener

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

  • scope the publish SIGINT handler to the active publish operation
  • remove the handler after both successful and failed publishes
  • add regressions for resolve and reject paths

Why

The publish command removed its one-time SIGINT listener only in the error path. Every successful programmatic publish left a listener attached, eventually causing listener warnings and cancelling stale packagers when a later SIGINT arrived.

Tests

  • TEST_FILES=publishSignalTest corepack pnpm ci:test
  • corepack pnpm compile
  • corepack pnpm ci:validate
  • git diff --check

Breaking changes

None.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4362f7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant