Skip to content

perf: make module downward search linear - #10149

Open
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/linear-module-downward-search
Open

perf: make module downward search linear#10149
OskarEichler wants to merge 1 commit into
electron-userland:masterfrom
OskarEichler:codex/linear-module-downward-search

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary

  • replace repeated queue shift() calls with an advancing index
  • preserve breadth-first traversal order and search limits

Why

Downward node-module discovery can explore up to 2,000 directories. Removing from the front of the array shifts every remaining entry, turning queue management into quadratic work.

Tests

  • TEST_FILES=moduleManagerTest corepack pnpm ci:test (22 passing)
  • corepack pnpm compile
  • corepack pnpm ci:validate
  • git diff --check

Breaking changes

None.

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 29178c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant