Add support for multi-tenant queries in streaming search - #1
Closed
electron0zero wants to merge 7 commits into
Closed
Add support for multi-tenant queries in streaming search#1electron0zero wants to merge 7 commits into
electron0zero wants to merge 7 commits into
Conversation
* Make autocomplete filtering default to true * chlog
electron0zero
force-pushed
the
add_federation
branch
from
December 14, 2023 22:04
71c0ee3 to
54644a9
Compare
electron0zero
force-pushed
the
mt_search_streaming
branch
from
December 14, 2023 22:06
75ae732 to
969dbb3
Compare
* page caching first pass Signed-off-by: Joe Elliott <number101010@gmail.com> * set default vals Signed-off-by: Joe Elliott <number101010@gmail.com> * actually return cache Signed-off-by: Joe Elliott <number101010@gmail.com> * disallow none cache Signed-off-by: Joe Elliott <number101010@gmail.com> * restore buffered reader Signed-off-by: Joe Elliott <number101010@gmail.com> * fix read buffer size Signed-off-by: Joe Elliott <number101010@gmail.com> * remove load Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * fix stopping behavior Signed-off-by: Joe Elliott <number101010@gmail.com> * copy before storing parquet pages Signed-off-by: Joe Elliott <number101010@gmail.com> * combined cached reader and optimized reader Signed-off-by: Joe Elliott <number101010@gmail.com> * lint/asserts Signed-off-by: Joe Elliott <number101010@gmail.com> * simplify needsCopy Signed-off-by: Joe Elliott <number101010@gmail.com> * add parquet-pages to docs Signed-off-by: Joe Elliott <number101010@gmail.com> * add stoewer file? Signed-off-by: Joe Elliott <number101010@gmail.com> * perhaps this incantation will work, mused the lonely wizard Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
* Add combiners to frontend --------- Co-authored-by: Mario <mariorvinas@gmail.com> * Add MultiTenantQueriesEnabled config in frontend * Add MultiTenantMiddleware and tests --------- Co-authored-by: Mario <mariorvinas@gmail.com> * Expose dedicated handler in queryfrontend for each http endpoint * Add multi-tenant middleware in multi-tenant routes * ignore e2e test folder * fix up * search methods on client * Add e2e test TestMultiTenantSearch * Add NewSearchTagsV2 combiner * test are passing... * test cleanup * docs & todos * make lint happy * use distinct value collector * Add docs * remove callback from combiner AddRequest * leave a todo to merge CombineSearchResults * return multi-tenant query unsupported for metrics endpoint * add a note on testing search streaming locally * update docs for lowercase headers * streaming search endpoints unsupported error * multi-tenant works in streaming search? who knows? * remove todo * update gitignore & local docker-compose file * test unsupported endpoints in e2e search * Update CHANGELOG.md * Add tests for unsupprted endpoints * more cleanup * fix lint * fix golangci * assert response for tags endpoints * docs feedback Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com> * reword and fix docs --------- Co-authored-by: Mario <mariorvinas@gmail.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
electron0zero
force-pushed
the
mt_search_streaming
branch
from
December 26, 2023 16:10
969dbb3 to
7b61b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add multi-tenant query support in streaming Search endpoints does not support multi-tenant queries.
follow up on grafana#3087
Which issue(s) this PR fixes:
Fixes grafana#1858
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]