Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinybird: compatibility with Tinybird Forward #387

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

eclbg
Copy link
Contributor

@eclbg eclbg commented Apr 3, 2025

Hey there, I'm an engineer at Tinybird.

As you might already know, we've recently released Tinybird Forward, a new iteration of our product to make building software with big data requirements faster and more intuitive. We're checking open source projects that use Tinybird to ensure their workspaces are compatible with it. This small PR achieves that.

I've just added TYPE endpoint to endpoint pipes. This was the default in Tinybird Classic, and has to be explicit in Tinybird Forward.

Let me know if this PR is welcome, or if you have any questions.

Cheers,

Summary by CodeRabbit

  • Chores
    • Refined internal endpoint classifications for backend data queries, ensuring consistency without impacting existing functionality.
Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

The changes add a new type declaration, TYPE endpoint, to two SQL pipe files. No existing logic or functionality is altered. The declaration explicitly categorizes the SQL endpoints in the respective pipes.

Changes

File(s) Change Summary
packages/…/aiCalls.pipe, packages/…/get_email_actions_by_period.pipe Added a new TYPE endpoint declaration to classify the SQL endpoints without altering existing logic.

Poem

I'm a rabbit hopping with cheer,
A new endpoint now appears so clear.
TYPE declarations set the pace,
Guiding SQL queries with gentle grace.
Code carrots crunch in every byte,
In this joyful garden, all is bright!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f04439f and cc55a81.

📒 Files selected for processing (2)
  • packages/tinybird-ai-analytics/pipes/aiCalls.pipe (1 hunks)
  • packages/tinybird/pipes/get_email_actions_by_period.pipe (1 hunks)
🔇 Additional comments (2)
packages/tinybird/pipes/get_email_actions_by_period.pipe (1)

16-16: Added TYPE endpoint for Tinybird Forward compatibility.

This change properly adds the explicit type declaration required by Tinybird Forward, which was previously handled implicitly in Tinybird Classic. The addition ensures backward compatibility while maintaining the same functionality.

packages/tinybird-ai-analytics/pipes/aiCalls.pipe (1)

70-70: Added TYPE endpoint for Tinybird Forward compatibility.

This change correctly adds the explicit endpoint type declaration needed for compatibility with Tinybird Forward. This is consistent with the similar change in the other pipe file and maintains functionality while ensuring compatibility with the new version.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Apr 3, 2025

@eclbg is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@elie222 elie222 merged commit eae229d into elie222:main Apr 3, 2025
2 of 3 checks passed
@elie222
Copy link
Owner

elie222 commented Apr 3, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants