fix: remove unreachable null checks flagged by Sonar (S2583) - #1755
Merged
Conversation
Request and Message.role are guaranteed non-null by their respective contracts (Spring AI's ChatModelObservationContext and Kotlin's Message.role), making these defensive checks dead code. Signed-off-by: Charles <azanux@gmail.com>
igordayen
approved these changes
Jul 1, 2026
igordayen
left a comment
Contributor
There was a problem hiding this comment.
all good, except UnfoldingToolInjectionStrategy, just extra line?
Collaborator
Author
|
For the space, I don’t think it was done on purpose. Maybe I was trying to remove something in another file, and the cursor happened to be focused on this file. |
Collaborator
Author
|
@igordayen revert done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unreachable null checks flagged by Sonar (S2583)
Summary
java:S2583("condition always evaluates to false") on the new-code leak period.ChatModelObservationFilter.buildInputMessages/extractPrompt:chatContext.getRequest()is guaranteed non-null by Spring AI'sChatModelObservationContextcontract, so theif (request == null)guards were unreachable.ObservationUtils.formatMessages:Message.roleis a non-nullable Kotlinval, so them.getRole() == nullcheck was unreachable.Test plan
mvn -pl embabel-agent-observability -am compile -DskipTestsmvn -pl embabel-agent-observability test -Dtest=ChatModelObservationFilterTest,ObservationUtilsTest