fix: use a catch-all media route for slashed storage keys - #182
Merged
Conversation
🦋 Changeset detectedLatest commit: c870759 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
masonjames
force-pushed
the
codex/media-route-catchall
branch
from
April 5, 2026 15:33
7979133 to
3634b72
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the injected Astro media route to use a catch-all parameter so storage keys containing / resolve correctly, and adds unit tests to validate behavior.
Changes:
- Update core route injection to mount the media file endpoint as
/_emdash/api/media/file/[...key]. - Add a new catch-all media file API handler that serves files from storage using the full slashed key.
- Add Vitest coverage for route injection and for slashed/missing keys.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/astro/integration/routes.ts | Switches injected media file route from single-segment [key] to catch-all [...key]. |
| packages/core/src/astro/routes/api/media/file/[...key].ts | Implements GET handler for serving files by catch-all storage key (supports slashes). |
| packages/core/tests/unit/astro/routes.test.ts | Adds tests ensuring the injected route uses [...key] and that slashed/missing keys behave correctly. |
| .changeset/blue-poems-laugh.md | Adds a patch changeset describing the bug fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ascorbic
enabled auto-merge (squash)
April 11, 2026 09:18
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
fmhall
pushed a commit
to fmhall/emdash
that referenced
this pull request
Apr 13, 2026
…#182) * fix media route for slashed storage keys * chore: add changeset for media route catch-all --------- Co-authored-by: Matt Kane <mkane@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the injected Astro media route to use a catch-all path so storage keys containing slashes resolve correctly.
It also adds route-level tests that verify slashed keys reach the handler intact and that missing keys return 404 cleanly.
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
pnpm --silent lint:quickpnpm --filter emdash exec vitest run tests/unit/astro/routes.test.tspnpm typecheckpnpm --silent lint:json | jq '.diagnostics | length'