fix(admin): accept relative URLs in menu editor - #349
Merged
ascorbic merged 7 commits intoApr 11, 2026
Conversation
Change URL inputs from type="url" to type="text" with a pattern that accepts absolute URLs (https://...) and relative paths (/...). Browser validation on type="url" rejected relative paths like /about, which are the most common use case for menu items. Closes emdash-cms#342
🦋 Changeset detectedLatest commit: 780713e The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
ascorbic
approved these changes
Apr 11, 2026
ascorbic
left a comment
ascorbic
left a comment
Collaborator
There was a problem hiding this comment.
Most of this was fixed in another PR, but the form updates are a good fix so I'll merge this too
ascorbic
enabled auto-merge (squash)
April 11, 2026 11:47
fmhall
pushed a commit
to fmhall/emdash
that referenced
this pull request
Apr 13, 2026
* fix(admin): accept relative URLs in menu editor Change URL inputs from type="url" to type="text" with a pattern that accepts absolute URLs (https://...) and relative paths (/...). Browser validation on type="url" rejected relative paths like /about, which are the most common use case for menu items. Closes emdash-cms#342 * Add changeset for menu editor URL fix --------- Co-authored-by: Matt Kane <mkane@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The menu editor's URL input used
type="url", which triggers browser validation requiring a full URL with scheme. This rejected relative paths like/aboutor/blog, which are the most common use case for internal menu links.Changes
type="url"totype="text"with apatternattribute that accepts:https://example.com,http://example.com/path/about,/blog/post-1,/And rejects invalid values like bare domains (
example.com) or schemeless input (about).Both the add form and edit form inputs are updated.
Closes #342
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output