fix: replace code block with section in webhook notifier payload preview - #463
Merged
ascorbic merged 2 commits intoApr 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 08c1a27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
ascorbic
enabled auto-merge (squash)
April 11, 2026 21:05
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
fmhall
pushed a commit
to fmhall/emdash
that referenced
this pull request
Apr 13, 2026
…iew (emdash-cms#463) * fix: replace code block with section in webhook notifier payload preview * chore: add changeset for webhook notifier fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The webhook notifier settings page was crashing in the admin UI when opened. The error was:
This happened because the settings page used a
{ type: "code", language: "json" }block to render the payload preview. This triggered the admin renderer's syntax highlighter, which crashed when it could not find the JSON language definition.Fixed by replacing the
type: "code"block with atype: "section"block that renders the payload preview as plain fenced markdown text — no syntax highlighter involved.Issue: #440
To reproduce:
webhookNotifierPlugin()inastro.config.mjsTypeError: Cannot read properties of undefined (reading 'classes')To verify the fix:
pnpm --filter @emdash-cms/plugin-webhook-notifier buildCloses #440
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
Before: Page crashes with
TypeError: Cannot read properties of undefined (reading 'classes')and shows "Something went wrong".After: Webhook notifier settings page loads normally with the payload preview visible and zero console errors.