Make readlink system call not resolve the link#23000
Merged
sbc100 merged 3 commits intoemscripten-core:mainfrom Nov 26, 2024
Merged
Make readlink system call not resolve the link#23000sbc100 merged 3 commits intoemscripten-core:mainfrom
sbc100 merged 3 commits intoemscripten-core:mainfrom
Conversation
hoodmane
force-pushed
the
readlink-noresolve
branch
from
c1cfa16 to
d75b1be
Compare
Readlink in linux does not resolve the link, it returns the exact link contents.
hoodmane
force-pushed
the
readlink-noresolve
branch
from
d75b1be to
5bc3f08
Compare
Collaborator
Author
|
@sbc100 test failure looks like it may be a flake? |
sbc100
reviewed
Nov 26, 2024
sbc100
reviewed
Nov 26, 2024
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm! great to see the test simplification!
sbc100
approved these changes
Nov 26, 2024
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I love how simple this fix is! Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readlink in linux does not resolve the link, it returns the exact link contents. Resolves #22999.