Skip to content

Fix for gen-delims escaping behaviour in path/query/fragment - #2701

Merged
lovelydinosaur merged 1 commit into
masterfrom
fix-gen-delims-escaping
May 9, 2023
Merged

Fix for gen-delims escaping behaviour in path/query/fragment#2701
lovelydinosaur merged 1 commit into
masterfrom
fix-gen-delims-escaping

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Member

Fix which gen-delims need to be escaped for path/query/fragment components in URL.

  • path now allows : / [ ] @ instead of : @ /
  • query now allows : / [ ] @ ? instead of / ?
  • fragment now allows : / [ ] @ ? # instead of / ?

Closes #2694

@lovelydinosaur lovelydinosaur added the bug Something isn't working label May 9, 2023
@lovelydinosaur
lovelydinosaur requested a review from a team May 9, 2023 10:47

@musale musale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lovelydinosaur
lovelydinosaur merged commit ee432c0 into master May 9, 2023
@lovelydinosaur
lovelydinosaur deleted the fix-gen-delims-escaping branch May 9, 2023 13:20
@epenet

epenet commented May 14, 2023

Copy link
Copy Markdown
Contributor

Is there a plan to issue a hotfix/patch release for this?

@lovelydinosaur

Copy link
Copy Markdown
Member Author

@epenet Sure - would you (or anyone) like to attempt a pull request with a minor version bump.
I'll help guide through the process.

@epenet

epenet commented May 16, 2023

Copy link
Copy Markdown
Contributor

@epenet Sure - would you (or anyone) like to attempt a pull request with a minor version bump. I'll help guide through the process.

I created PR #2702, but I'm a little confused here as it seems there is already a v0.24.1 branch in progress: https://github.com/encode/httpx/tree/version-0.24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants