Skip to content

Change the type of Extensions from Mapping to MutableMapping. - #2803

Merged
karpetrosyan merged 9 commits into
encode:masterfrom
karpetrosyan:change-response-extensions-type
Sep 11, 2023
Merged

Change the type of Extensions from Mapping to MutableMapping.#2803
karpetrosyan merged 9 commits into
encode:masterfrom
karpetrosyan:change-response-extensions-type

Conversation

@karpetrosyan

Copy link
Copy Markdown
Contributor

Closes #2794

@karpetrosyan
karpetrosyan marked this pull request as draft August 1, 2023 12:49
@karpetrosyan

Copy link
Copy Markdown
Contributor Author

We need httpcore release to resolve this type error.

@lovelydinosaur

Copy link
Copy Markdown
Member

We need httpcore release to resolve this type error.

Okay, shall we add httpcore @ git+https://github.com/encode/httpcore@master to the requirements.txt in this PR to demo that this'd resolve the type issues.

Comment thread pyproject.toml
@karpetrosyan
karpetrosyan marked this pull request as ready for review August 7, 2023 14:04
@karpetrosyan
karpetrosyan marked this pull request as draft August 7, 2023 14:09
@trim21

trim21 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

looks like we can continue on this issue?

@karpetrosyan
karpetrosyan marked this pull request as ready for review September 8, 2023 19:02
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Sep 11, 2023
- Bump PORTREVISION for package change

Obtained from:	encode/httpx#2803
@karpetrosyan
karpetrosyan merged commit adbcd0e into encode:master Sep 11, 2023
@karpetrosyan
karpetrosyan deleted the change-response-extensions-type branch September 11, 2023 06:29
@trim21 trim21 mentioned this pull request Sep 11, 2023
@lovelydinosaur lovelydinosaur changed the title Change extensions type Sep 11, 2023
samclearman pushed a commit to titanmsp/httpx that referenced this pull request Apr 26, 2025
* Change extensions type

* Update changelog

* install httpcore from the git

* Revert "install httpcore from the git"

This reverts commit 1813c6a.

* bump httpcore version

* fix requirements

---------

Co-authored-by: Tom Christie <tom@tomchristie.com>
camachat pushed a commit to camachat/freebsd-ports that referenced this pull request Jul 22, 2026
- Bump PORTREVISION for package change

Obtained from:	encode/httpx#2803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants