Raise ValueError on Response.encoding being set after Response.text has been accessed - #2852
Merged
lovelydinosaur merged 3 commits intoSep 19, 2023
Conversation
Member
|
Okay yes, as discussed this is probably a marginal improvement in behaviour. Thanks. |
lovelydinosaur
requested changes
Sep 17, 2023
Member
|
What's a more precise title for this PR? |
Author
|
Modified. I'm not proficient in English, please change it if it's not appropriate. |
karpetrosyan
approved these changes
Sep 18, 2023
lovelydinosaur
left a comment
lovelydinosaur
left a comment
Member
There was a problem hiding this comment.
All looking great, thanks. 😊
I think we just need to update the CHANGELOG.md, then this is good to go.
lovelydinosaur
approved these changes
Sep 19, 2023
Merged
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
…t` has been accessed (encode#2852) * Raise ValueError on change encoding * Always raise ValueError for simplicity * update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #2041
Summary
After
Response.textis accessed, if you try to changeResponse.encoding, nothing happens. So just raise an Exception on change toencodingaftertextis accessed.Checklist