Allow URLs where username or password contains unescaped '@'. - #2986
Merged
Conversation
lovelydinosaur
marked this pull request as ready for review
December 6, 2023 14:07
zanieb
approved these changes
Dec 6, 2023
|
Hopefully this change will be released soon so I can continue using the proxy with httpx |
Contributor
|
@tomchristie could you improve the title too? |
lovelydinosaur
commented
Dec 7, 2023
Merged
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
…#2986) * Add test cases for userinfo in URL * Resolve failing test cases * Update CHANGELOG.md * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/encode/httpx/issues/2985.