Ensure that ASGI 'raw_path' does not include query component of URL. - #2999
Merged
Conversation
…to fix-asgi-rawpath
lovelydinosaur
marked this pull request as ready for review
December 11, 2023 14:32
zanieb
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2810.
Update the ASGI transport to ensure that
raw_pathdoes not include the query component.The spec was originally a little ambiguous here, and it might(?) have made sense for it to include the query portion, since that way around it'd be a direct representation of the HTTP/1.1 target byte string that was received on the wire. But the spec's been clarified since, and we're not matching that correctly at the moment. Let's fix that!☺️