docs: fix the timeout behavior explanation #41783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/41783/docs/index.html The docs are (re-)rendered each time the CI |
phlax
reviewed
Oct 31, 2025
There was a problem hiding this comment.
tiny literal nit but otherwise looks like a really nice cleanup/addition
would be good to get sign off from @adisuissa for what is being said
|
@krajshiva can you PTAL, as you may have the most context |
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We clarified the max_connection_duration behavior as part of this but this change was never done for the docs we have on "How do I configure timeouts?" here.
This PR is making the same changes to the main doc.
Commit Message: docs: fix the timeout behavior explanation
Additional Description: Fix the main timeout docs to align with the proto docs.
Risk Level: N/A
Testing: CI
Docs Changes: Added
Release Notes: N/A