Report load when rq active is non-zero. #41786
Open
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
/assign @adisuissa |
|
/retest |
adisuissa
reviewed
Oct 31, 2025
Comment on lines
152
to
153
| // rq_issued is zero(no requests have been issued in this poll | ||
| // window), some load balancer may need rq_active for load balancing. |
There was a problem hiding this comment.
Suggested change
| // rq_issued is zero(no requests have been issued in this poll | |
| // window), some load balancer may need rq_active for load balancing. | |
| // rq_issued is zero (no new requests have been issued in this poll | |
| // window). This is needed to report long-lived connections/requests (e.g., when web-sockets are used). |
Comment on lines
+551
to
+552
| scoped_runtime.mergeValues( | ||
| {{"envoy.reloadable_features.report_load_when_rq_active_is_non_zero", "true"}}); |
There was a problem hiding this comment.
This will be enabled by default, but it is still ok to enable this here so if a user disables it by default the test will still pass.
Please add a comment stating that when the runtime flag is deprecated this test should be kept, to avoid confusion.
There was a problem hiding this comment.
Good point, done.
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
stevenzzzz
commented
Oct 31, 2025
Comment on lines
152
to
153
| // rq_issued is zero(no requests have been issued in this poll | ||
| // window), some load balancer may need rq_active for load balancing. |
Comment on lines
+551
to
+552
| scoped_runtime.mergeValues( | ||
| {{"envoy.reloadable_features.report_load_when_rq_active_is_non_zero", "true"}}); |
There was a problem hiding this comment.
Good point, done.
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @RyanTheOptimist |
|
Please fix CI issue. |
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
Signed-off-by: Xin Zhuang <stevenzzz@google.com>
|
Thanks, done. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: If rq_active is non-zero, we should send the locality stats even if rq_issued is zero(no requests have been issued in this poll window), some load balancer may need rq_active for load balancing.
Additional Description:
Risk Level: LOW (use or not completely decided by remote loadbalancer
Testing: unit test
Docs Changes: guarded by runtime
envoy_reloadable_features_report_load_when_rq_active_is_non_zeroRelease Notes: Added runtime guard
envoy.reloadable_features.report_load_when_rq_active_is_non_zero, When enabled, LRS continues to send locality_stats reoprt to config server when there is no request_issued in the poll cycle.Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]