add capacity where appends in for can be easily precalculated for less reallocation #32088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudzie3107
approved these changes
Jun 24, 2025
core/blockchain.go
Outdated
| @@ -2211,7 +2211,7 @@ func (bc *BlockChain) insertSideChain(block *types.Block, it *insertIterator, ma | |||
| } | |||
| // Import all the pruned blocks to make the state available | |||
| var ( | |||
| blocks []*types.Block | |||
| blocks = make([]*types.Block, 0, len(hashes)) | |||
There was a problem hiding this comment.
it's not correct. If the size of blocks exceed 2k, then the held blocks will be inserted and the slice blocks will be rotated.
There was a problem hiding this comment.
reverted. It focused on the first loop to fit that.
core/rawdb/ancient_utils.go
Outdated
| @@ -53,6 +53,7 @@ func (info *freezerInfo) size() common.StorageSize { | |||
|
|
|||
| func inspect(name string, order map[string]freezerTableConfig, reader ethdb.AncientReader) (freezerInfo, error) { | |||
| info := freezerInfo{name: name} | |||
| info.sizes = make([]tableSize, 0, len(order)) | |||
There was a problem hiding this comment.
unnecessary to pre-allocate, the number of freezer instances is very limited
core/rawdb/ancient_utils.go
Outdated
| @@ -78,7 +79,7 @@ func inspect(name string, order map[string]freezerTableConfig, reader ethdb.Anci | |||
|
|
|||
| // inspectFreezers inspects all freezers registered in the system. | |||
| func inspectFreezers(db ethdb.Database) ([]freezerInfo, error) { | |||
| var infos []freezerInfo | |||
| var infos []freezerInfo = make([]freezerInfo, 0, len(freezers)) | |||
There was a problem hiding this comment.
unnecessary to pre-allocate, the number of freezer instances is very limited
core/vm/eips.go
Outdated
| @@ -60,7 +60,7 @@ func ValidEip(eipNum int) bool { | |||
| return ok | |||
| } | |||
| func ActivateableEips() []string { | |||
| var nums []string | |||
| nums := make([]string, 0, len(activators)) | |||
There was a problem hiding this comment.
unnecessary to pre-allocate, the number of EIPs is very limited
core/vm/interpreter.go
Outdated
| @@ -136,11 +136,12 @@ func NewEVMInterpreter(evm *EVM) *EVMInterpreter { | |||
| default: | |||
| table = &frontierInstructionSet | |||
| } | |||
| var extraEips []int | |||
| extraEips := make([]int, 0, len(evm.Config.ExtraEips)) | |||
There was a problem hiding this comment.
unnecessary to pre-allocate, the number of EIPs is very limited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for loops, which fill slices with append, should use capacity for slice(else 0 and reallocations during growing)