Skip to content

common/bitutil: optimize TestBytes #33334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cuiweixie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common/bitutil: optimize TestBytes #33334

cuiweixie wants to merge 1 commit into from
+184 −25

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Nov 30, 2025 

goos: darwin
goarch: arm64
pkg: github.com/ethereum/go-ethereum/common/bitutil
cpu: Apple M1 Pro
               │    old.txt    │               new.txt               │
               │    sec/op     │   sec/op     vs base                │
FastTest1KB-10    335.05n ± 4%   10.97n ± 1%  -96.73% (p=0.000 n=10)
FastTest2KB-10    654.50n ± 2%   21.16n ± 4%  -96.77% (p=0.000 n=10)
FastTest4KB-10   1290.00n ± 0%   41.28n ± 0%  -96.80% (p=0.000 n=10)
geomean            656.5n        21.24n       -96.76%

               │   old.txt    │               new.txt               │
               │     B/op     │    B/op     vs base                 │
FastTest1KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
FastTest2KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
FastTest4KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                     ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

               │   old.txt    │               new.txt               │
               │  allocs/op   │ allocs/op   vs base                 │
FastTest1KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
FastTest2KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
FastTest4KB-10   0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=10) ¹
geomean                     ²               +0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean
@gballet gballet self-assigned this Dec 14, 2025
gballet
gballet reviewed Dec 14, 2025
View reviewed changes
@fjl fjl added this to the 1.16.9 milestone Dec 16, 2025
@gballet gballet assigned fjl and unassigned gballet Dec 30, 2025
@gballet gballet self-assigned this Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@cuiweixie @gballet @fjl