rpc: add generic OpenTelemetry tracing for JSON-RPC calls #33452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhea
force-pushed
the
rpc-otel-tracing
branch
from
f99f204 to
cb45359
Compare
jrhea
force-pushed
the
rpc-otel-tracing
branch
from
7c245f1 to
c35e582
Compare
Contributor
Author
|
@fjl I am getting this error when the lint step is run: https://github.com/ethereum/go-ethereum/actions/runs/20384597266/job/58582793251?pr=33452 looks like the otel dependencies I added to geth changed some transitive dependencies and now they don't match what is in cmd/keeper. I can get it to pass by running |
jrhea
force-pushed
the
rpc-otel-tracing
branch
from
bc7b9b3 to
9cb042d
Compare
jrhea
force-pushed
the
rpc-otel-tracing
branch
from
04615b8 to
fa8860d
Compare
jrhea
commented
Dec 30, 2025
|
|
||
| // Start tracing span before invoking the subscription method. | ||
| ctx, span := h.startSpan(cp.ctx, msg, cp.isBatch) | ||
| defer span.End() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds generic OpenTelemetry tracing to the JSON-RPC server in
package rpc.Tracing is disabled by default by relying on the global OpenTelemetry tracer provider, which is a noop unless configured elsewhere. Server.SetTracerProvider is supported for tests, but we might want to ditch this and just rely on helpers accessing the global provider.
Follow-ups