Skip to content

ethclient: omit nil address/topics from filter args #33464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
madisoncarter1234 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ethclient: omit nil address/topics from filter args #33464

madisoncarter1234 wants to merge 3 commits into from
+18 −3

Conversation

@madisoncarter1234
Copy link

@madisoncarter1234 madisoncarter1234 commented Dec 20, 2025

Fixes #33369

Summary

  • Only include address and topics fields in filter args when non-nil
  • Prevents "address": null from being sent in JSON-RPC payload
  • Fixes compatibility with strict JSON-RPC validators (e.g., Hedera)

Test

Added test case for nil addresses scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@madisoncarter1234