core: cleanup txlookup entries during chain rewind #33487
+43
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a todo on core/blockchain.go
It addresses the todo by cleaning up txlookup entries during a chain rewind. When delFn deletes a block body, it now iterates through the transactions and removes their corresponding lookup indices, preventing stale "zombie" entries from persisting in the database. A regression test TestSetHeadTxLookupCleanup has been added to verify this behavior.