core/state, core/tracing: new state update hook #33490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiihann
force-pushed
the
feat/state-update-hook
branch
from
672b701 to
752e16a
Compare
weiihann
force-pushed
the
feat/state-update-hook
branch
4 times, most recently
from
7df337b to
1d415b4
Compare
add statesize tracer create file debug log deal with genesis debug logs fix storage bytes fix storage fix storage 2 Revert "fix storage 2" This reverts commit cfbefaa. Revert "fix storage" This reverts commit 62a4189. Revert "fix storage bytes" This reverts commit 1b42707. fix storage 3 remove debug logs remove lint lint chore revert lint fix lint fix nil add depth count debug depth created and deleted nodes
weiihann
force-pushed
the
feat/state-update-hook
branch
from
ab2f926 to
abbe71b
Compare
core/tracing/hooks.go
Outdated
| type CodeChange struct { | ||
| Hash common.Hash | ||
| Code []byte | ||
| Exists bool // true if the code already deployed before |
Member
There was a problem hiding this comment.
We should may be also expose the original value of the deployed code.
Originally the code is immutable and will never be changed since the deployment. With EIP-7702, it's possible to re-deploy the delegation.
Contributor
Author
|
Maybe I wasn't being clear. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
OnStateUpdatehook which gets invoked after state is committed.Rationale
For our particular use case, we need to obtain the state size metrics at every single block when fuly syncing from genesis. With the current state sizer, whenever the node is stopped, the background process must be freshly initialized. During this re-initialization, it can skip some blocks while the node continues executing blocks, causing gaps in the recorded metrics.
Using this state update hook allows us to customize our own data persistence logic, and we would never skip blocks upon node restart.
The
statesizetracer shows how the hook is used. Will remove once this PR is ready for merging.