Fix Test Cases [tests pass on all os] - #832
Conversation
…ests-add-coverage-cleanup-ignore-file
…-coverage-cleanup-ignore-file
There was a problem hiding this comment.
Thank you very much for contributing! First for feedback, this PR changes too many things to be easily evaluated.
Can you open an issue describing the things you are trying to fix or enhance individually? That makes it much easier to track discussions and focus on individual issues.
For example, I can't reproduce the tests failing. It might be a good idea to add more Node versions into CI, but that's it's own issue alone. As is adding code coverage. There's also formatting changes, this introduces a yarn.lock file, and ignores and disables package-lock files.
Also, there are 33 people who have contributed to this package in some way, but you'll notice that only 3 are listed as contributors in package.json. I'm not the person who decides who gets listed there, or how that works, but I wanted to point that out 😉
@jonchurch, thank you for your answer ..
|
c405b45 to
5c1ac0b
Compare
d637e43 to
0a32d17
Compare
0a32d17 to
a1329d1
Compare
|
I will close this PR due to lack of interaction .. |
nycistanbul.merge #831 #830 #829 here ..
fix #181 #827 #829 ..