Detect Phoenix as Neoverse V3 for perf hook#687
Open
charles-typ wants to merge 1 commit into
Open
Conversation
Summary: Phoenix/Rainier hosts report the CPU as `Neoverse-V3AE` in `lscpu` Model name, but the Benchpress perf hook only detected Neoverse V3 from DMI system-family/system-version strings. When DMI detection missed Phoenix, the `perf` hook fell back to the generic ARM topdown-tool path. That path can install/run Arm topdown-tool at benchmark time and emit setup output to stdout before Automark JSON. Teach the Neoverse V3 selector to also recognize `lscpu` Model name strings such as `Neoverse-V3AE`, while preserving the existing DMI checks. This makes Phoenix use the packaged Neoverse V3 perfutils (`collect_neoversev3_perf_counters.sh` and `generate_arm_neoversev3_perf_report.py`) instead of generic ARM topdown-tool. Differential Revision: D108616598
meta-cla
Bot
added
the
CLA Signed
|
@charles-typ has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108616598. |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jun 15, 2026
Summary: Pull Request resolved: #687 Phoenix/Rainier hosts report the CPU as `Neoverse-V3AE` in `lscpu` Model name, but the Benchpress perf hook only detected Neoverse V3 from DMI system-family/system-version strings. When DMI detection missed Phoenix, the `perf` hook fell back to the generic ARM topdown-tool path. That path can install/run Arm topdown-tool at benchmark time and emit setup output to stdout before Automark JSON. Teach the Neoverse V3 selector to also recognize `lscpu` Model name strings such as `Neoverse-V3AE`, while preserving the existing DMI checks. This makes Phoenix use the packaged Neoverse V3 perfutils (`collect_neoversev3_perf_counters.sh` and `generate_arm_neoversev3_perf_report.py`) instead of generic ARM topdown-tool. Reviewed By: YifanYuan3 Differential Revision: D108616598 fbshipit-source-id: c0c9793ed418edef913163ed26690bc9e048d07d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Phoenix/Rainier hosts report the CPU as
Neoverse-V3AEinlscpuModel name, but the Benchpress perf hook only detected Neoverse V3 from DMI system-family/system-version strings.When DMI detection missed Phoenix, the
perfhook fell back to the generic ARM topdown-tool path. That path can install/run Arm topdown-tool at benchmark time and emit setup output to stdout before Automark JSON.Teach the Neoverse V3 selector to also recognize
lscpuModel name strings such asNeoverse-V3AE, while preserving the existing DMI checks. This makes Phoenix use the packaged Neoverse V3 perfutils (collect_neoversev3_perf_counters.shandgenerate_arm_neoversev3_perf_report.py) instead of generic ARM topdown-tool.Differential Revision: D108616598