Skip to content

Replace via.placeholder.com with placehold.co#3056

Open
runephilosof-abtion wants to merge 1 commit intofaker-ruby:mainfrom
runephilosof-abtion:patch-1
Open

Replace via.placeholder.com with placehold.co#3056
runephilosof-abtion wants to merge 1 commit intofaker-ruby:mainfrom
runephilosof-abtion:patch-1

Conversation

@runephilosof-abtion
Copy link
Copy Markdown

@runephilosof-abtion runephilosof-abtion commented Mar 5, 2025

Fixes #3055

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.
@runephilosof-abtion
Copy link
Copy Markdown
Author

runephilosof-abtion commented Mar 5, 2025

Oops. I did not check the differences in the APIs.
placehold.co does not support just specifying a background color.
If you specify one, you must specify the other.

What color did via.placeholder.com use when only specifying the background color?
I assumed the defaults were black on white and that specifying one would only change that one. So I retained that functionality.

Will push the new commit soon ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant