fix(terminal): resolve Claude launcher path on Unix#2407
Open
xpfo-go wants to merge 1 commit intofarion1231:mainfrom
Open
fix(terminal): resolve Claude launcher path on Unix#2407xpfo-go wants to merge 1 commit intofarion1231:mainfrom
xpfo-go wants to merge 1 commit intofarion1231:mainfrom
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
claudewhen GUI-launched PATH is minimal.claudeexecutable from current PATH plus common install locations such as~/.local/bin, Volta, nvm/fnm, Homebrew, and system bin directories.bash --norc --noprofile.Related Issue / 关联 Issue
Fixes #2402
Screenshots / 截图
Not applicable; backend terminal-launch behavior only.
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查（如修改了 Rust 代码）Test Plan / 测试计划
pnpm typecheck && pnpm format:check && pnpm test:unitcd src-tauri && cargo fmt --check && cargo clippy && cargo testclaudefails with stripped PATH and succeeds when common CLI paths are injected.