Fix fieldsets to follow Bootstrap usage recommendations#635
Open
markhoney wants to merge 1 commit intofarridav:mainfrom
Open
Fix fieldsets to follow Bootstrap usage recommendations#635markhoney wants to merge 1 commit intofarridav:mainfrom
markhoney wants to merge 1 commit intofarridav:mainfrom
Conversation
Currently Jazzmin inserts all fields in a Django "field group" into a single Bootstrap "field-group" div. However Django field groups and the Bootstrap concept of a field group are not the same thing, meaning that forms with multiple fields in a row break the layout. A bootstrap field group should only contain a single label and input pair, and layout of the fields should be controlled with the row and col classes (see https://getbootstrap.com/docs/4.6/components/forms/). My edits follow this design pattern, and place each Django field group in a row, with each individual field in a form-group that is also a col.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Jazzmin inserts all fields in a Django "field group" into a single Bootstrap "field-group" div. However Django field groups and the Bootstrap concept of a field group are not the same thing, meaning that forms with multiple fields in a row break the layout.
A bootstrap field group should only contain a single label and input pair, and layout of the fields should be controlled with the row and col classes (see https://getbootstrap.com/docs/4.6/components/forms/). My edits follow this design pattern, and place each Django field group in a row, with each individual field in a form-group that is also a col.