feat: validate existing email and set 201 status on user creation - #2239
Open
Sergy988 wants to merge 1 commit into
Open
feat: validate existing email and set 201 status on user creation#2239Sergy988 wants to merge 1 commit into
Sergy988 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces three small but important improvements to the user creation endpoint:
Email Validation: Added a check using crud.get_user_by_email to verify if the user already exists. If it does, it now properly raises an HTTPException with a 400 status code, preventing database errors or silent failures.
Correct HTTP Status: Added status_code=status.HTTP_201_CREATED to the router decorator to correctly reflect the creation of a new resource.
Keyword-only Arguments: Added the * symbol in the function signature to enforce keyword-only arguments, adhering to FastAPI and Python best practices.