Skip to content

feat: extract markdown for PDF pages with password - #444

Open
aynugek wants to merge 2 commits into
firecrawl:mainfrom
aynugek:main
Open

feat: extract markdown for PDF pages with password#444
aynugek wants to merge 2 commits into
firecrawl:mainfrom
aynugek:main

Conversation

@aynugek

@aynugek aynugek commented Aug 21, 2026

Copy link
Copy Markdown

Summary by cubic

Adds password support to per-page Markdown extraction so encrypted PDFs can be processed. Previously extract_pages_markdown failed on encrypted PDFs; now callers can pass a password, and an empty password is tried by default. Wrong or missing passwords return an Encrypted error.

API changes

  • Rust: added extract_pages_markdown_with_password and extract_pages_markdown_mem_with_password; existing functions delegate with None.
  • Python: extract_pages_markdown and extract_pages_markdown_bytes accept an optional password; stubs and docs updated.
  • Node (N-API): extract_pages_markdown and extract_pages_markdown_async accept an optional password; existing two-arg calls continue to work.

Notes

  • Encrypted files without a correct password return PdfError::Encrypted, propagated to Python and Node.
  • Rust and Python API docs updated; new integration test covers decryption and error cases.

Written for commit 4c90d4d. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Shadow auto-approve: would auto-approve. Adds optional password support for extract_pages_markdown in Rust core and Python/Node bindings with a new integration test. Backward compatible, documented, and tested; no risky changes are visible, so auto-approval.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant