Publish a darwin-x64 (Intel macOS) Node binding - #468
Open
wenzhengjiang wants to merge 1 commit into
Open
Conversation
The npm package has no @firecrawl/pdf-inspector-darwin-x64, so Intel Macs fail at require() even though index.js already has a darwin/x64 branch. Build and smoke-test x86_64-apple-darwin on macos-15-intel, the same runner the Python wheel already uses, and publish it like the other platform packages.
![cubic-dev-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Shadow auto-approve: would require human review. Adds Intel macOS (darwin-x64) support to the napi package, build matrix, and optionalDependencies. This expands the supported platform set and publishes a new binary; the verification is only on a fork and not visible in the diff.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@firecrawl/pdf-inspectorhas nodarwin-x64platform package, so on an Intel Macrequire("@firecrawl/pdf-inspector")fails even though the generatedindex.jsalready has adarwin+x64branch. We ship pdf-inspector inside Miyo, an Electron app, and this is the one dependency keeping us from an Intel macOS build.What
x86_64-apple-darwinto the build and smoke-test matrices inpublish.yml, on GitHub'smacos-15-intelrunner.publish-pypi.ymlalready uses that runner for the Intel wheel.darwin-x64entry to the platform-package metadata map,napi.targets, andoptionalDependencies.PDFium and ONNX Runtime are loaded at runtime, so the build needs nothing beyond the Rust target. As
docs/ocr-runtime.mdalready notes for the Python wheel, ONNX Runtime 1.27.0 has no Intel macOS archive, so local OCR on that target still needs a custom build. Text extraction is unaffected.Verification
I ran the new matrix leg on my fork, on
macos-15-intel: the build producespdf-inspector.darwin-x64.node(Mach-O 64-bit dynamically linked shared library x86_64) andnapi/test.mjspasses against it. Run: https://github.com/wenzhengjiang/pdf-inspector/actions/runs/33236213976The publish step itself only runs on a
napi/package.jsonversion change frommain, so the next release exercises it.Summary by cubic
Adds an Intel macOS (
darwin-x64) binary for@firecrawl/pdf-inspectorso the package loads on Intel Macs instead of failing atrequire().x86_64-apple-darwinon themacos-15-intelrunner in the publish workflow.darwin-x64platform package innapi/package.jsonand documents it in the README.Local OCR still needs a custom ONNX Runtime build on Intel macOS; text extraction is unaffected.
Written for commit ab07538. Summary will update on new commits.