fix(loader): bound object-stream decompression at load (lopdf 0.44) - #478
Open
abimaelmartell wants to merge 2 commits into
Open
fix(loader): bound object-stream decompression at load (lopdf 0.44)#478abimaelmartell wants to merge 2 commits into
abimaelmartell wants to merge 2 commits into
Conversation
Some tagged PDFs pack their structure tree into object streams that inflate to ~1.5 GiB from a 21 MB file; lopdf expands every object stream eagerly at load, so one such document exhausts memory before any of our code runs. Bump lopdf 0.42 -> 0.44 and set its new max_decompressed_size load option (8 MiB per stream). Oversized streams are skipped by lopdf, and a zero-page check fails the load cleanly if the page tree itself got skipped. 0.44 made get_page_content infallible; adjusted the one call site. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
…rning Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update lopdf