refactor: assets module form cleanup (backport #52393)#52999
Open
khushi8112 wants to merge 11 commits intofrappe:version-16-hotfixfrom
Open
refactor: assets module form cleanup (backport #52393)#52999khushi8112 wants to merge 11 commits intofrappe:version-16-hotfixfrom
khushi8112 wants to merge 11 commits intofrappe:version-16-hotfixfrom
Conversation
(cherry picked from commit 4e7794b)
(cherry picked from commit f7b9221)
(cherry picked from commit c36fa5b)
(cherry picked from commit e90a3b5)
(cherry picked from commit f2f5092)
(cherry picked from commit e8e8d23)
(cherry picked from commit eb7932e)
(cherry picked from commit 9f7bfc0)
(cherry picked from commit d1b81b9)
(cherry picked from commit 4f59d58)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version-16-hotfix #52999 +/- ##
=====================================================
- Coverage 79.42% 79.41% -0.01%
=====================================================
Files 1182 1182
Lines 123971 123954 -17
=====================================================
- Hits 98459 98443 -16
+ Misses 25512 25511 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI / UX Improvements
is_existing_asset,is_composite_asset, andis_composite_componentfrom multiple checkboxes to a single select field for clearer intent and mutual exclusivity. Also wrote patch for this.calculate_depreciationout of the Depreciation tab into the Details section.The Depreciation tab is now shown only when depreciation is enabled, reducing visual noise.
item_name,asset_owner) to simplify the form.Overall, this improves clarity, reduces clutter, and makes asset-related workflows easier to follow without changing existing behavior.
Manual backport of pull request #52393