Skip to content

Fixed incorrect closed interior constant value - #41

Merged
frenck merged 1 commit into
frenck:mainfrom
beakerflo:Closed-interior
Dec 24, 2021
Merged

Fixed incorrect closed interior constant value#41
frenck merged 1 commit into
frenck:mainfrom
beakerflo:Closed-interior

Conversation

@beakerflo

@beakerflo beakerflo commented Dec 24, 2021

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe the changes and rationale behind them)

Related Issues

fixes #40

@sourcery-ai

sourcery-ai Bot commented Dec 24, 2021

Copy link
Copy Markdown

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 107.00 🙂 107.00 🙂 0.00
Working memory 4.00 ⭐ 4.00 ⭐ 0.00
Quality 82.33% 82.33% 0.00%
Other metrics Before After Change
Lines 52 52 0
Changed files Quality Before Quality After Quality Change
src/vehicle/const.py 82.33% ⭐ 82.33% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@frenck frenck changed the title Correct interior example 97-VH-XJ Dec 24, 2021
@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Dec 24, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #41 (18369a6) into main (9196c38) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          148       148           
  Branches        16        16           
=========================================
  Hits           148       148           
Impacted Files Coverage Δ
src/vehicle/const.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9196c38...18369a6. Read the comment docs.

@frenck frenck left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @beakerflo 👍

@frenck
frenck merged commit 5130c89 into frenck:main Dec 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

3 participants