Skip to content

Fixed ID type deserialization #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xperiandri wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Fixed ID type deserialization #410

xperiandri wants to merge 4 commits into from

Conversation

@xperiandri
Copy link
Collaborator

@xperiandri xperiandri commented Dec 7, 2022 •
edited
Loading

Rebase of #262
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from d9061cf to 8fd8170 Compare December 7, 2022 03:57
xperiandri
xperiandri commented Dec 15, 2022
View reviewed changes
Copy link
Collaborator Author

@xperiandri xperiandri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njlr any opinions?
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from a024d30 to 48c7715 Compare December 16, 2022 14:49
@xperiandri
Copy link
Collaborator Author

xperiandri commented Dec 17, 2022

@njlr review, please
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from 48c7715 to d2a746e Compare December 17, 2022 20:32
@mickhansen
Copy link
Collaborator

mickhansen commented Dec 28, 2022

How did this fail prior to this PR?
@njlr
Copy link
Contributor

njlr commented Dec 30, 2022

LGTM 👍
@ivelten ivelten closed this Jan 11, 2023
@ivelten ivelten reopened this Jan 11, 2023
ivelten
ivelten approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@ivelten ivelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@ivelten
Copy link
Collaborator

ivelten commented Jan 11, 2023

@njlr can you approve again? I accidentally closed the Pull Request.
@njlr
Copy link
Contributor

njlr commented Jan 11, 2023

@ivelten I don't have permissions

@xperiandri Can you help?
@xperiandri
Copy link
Collaborator Author

xperiandri commented Jan 12, 2023

This needs to be rebased or applied on top of #418
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from ee9baf6 to 5e02ca2 Compare February 24, 2023 15:52
@xperiandri xperiandri force-pushed the dev branch 4 times, most recently from c8b3525 to 0810527 Compare November 5, 2023 23:05
@xperiandri xperiandri force-pushed the dev branch 2 times, most recently from 14aa27a to 3ba4016 Compare February 15, 2024 20:39
@xperiandri xperiandri force-pushed the dev branch 2 times, most recently from 1737829 to 246d6c0 Compare February 25, 2024 13:02
@xperiandri xperiandri force-pushed the dev branch 2 times, most recently from 0dd4372 to 81bc85e Compare March 24, 2024 17:56
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from 5e02ca2 to 99dc46b Compare September 2, 2024 12:58
@xperiandri xperiandri force-pushed the ID_type_deserialization_fix branch from 99dc46b to 8f459ab Compare September 10, 2024 20:25
@xperiandri xperiandri force-pushed the dev branch 5 times, most recently from d90f0e9 to 434b4be Compare October 11, 2024 16:35
@xperiandri xperiandri force-pushed the dev branch 3 times, most recently from f3a1bf8 to 9d4b950 Compare December 1, 2025 00:26
@xperiandri xperiandri force-pushed the dev branch 2 times, most recently from 6dc591e to 85a9d8c Compare December 19, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@xperiandri @mickhansen @njlr @ivelten @hth313