Skip EnsureMinSize calls on mobile#6236
Merged
dweymouth merged 1 commit intofyne-io:developfrom Mar 29, 2026
Merged
Conversation
andydotxyz
approved these changes
Mar 28, 2026
Member
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
It's drastic but I cannot think of a reason not to - it is all fixed size screens...
Anyone else have an opinion before we just merge this idea in?
Contributor
No reason not to if for all mobile OS, they are in full control of window size anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When the RichText widget of this test app is being dragged,
*driver.handlePaintdraws become very slow on Android, see #6233. While dragging,canvasNeedRefreshistrueandc.EnsureMinSize()is called. TheseEnsureMinSizecalls take 4.36 ms on average (for the test app). Instead of trying to optimizeEnsureMinSize(as in #6234), this PR is more radical: It skips EnsureMinSize calls completely (on mobile).This might be wrong for some reason. But so far, I couldn't find any problems with it. Resizing the window in mobile simulation on Linux still works. Even split windows on Android work with this PR.
This should improve scrolling performance.
Checklist: