introduce new legacy_threading build tag, build is now migrated by de…#6255
Open
dweymouth wants to merge 1 commit intofyne-io:developfrom
Open
introduce new legacy_threading build tag, build is now migrated by de…#6255dweymouth wants to merge 1 commit intofyne-io:developfrom
dweymouth wants to merge 1 commit intofyne-io:developfrom
Conversation
Member
|
Thanks for marking this as 2.9 - the migration plan shows we need more serious warnings on the 2.8 release and then we can turn this on by default for develop after v2.8.0 goes out |
Member
|
On naming - wouldn't it be better to stick with the name we used before and pick "legacy_fynedo" I know it's kindof backwards - but then we have a process for future migrations whereby it's "migrated_xyz" followed by "legacy_xyz". Or maybe "disable_" instead of "legacy_" or another name? |
Member
|
Oh, I misread the milestone - this needs to go to "I", as per the doc we have: https://github.com/fyne-io/fyne/wiki/Threading-migration |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduces a new build tag
legacy_threadingand retires the oldmigrated_fynedotag. Code will now build as "migrated" by default including with a plaingo build.N.B.: The corresponding change to build.go will need to be made in the fyne-io/tools repository to set the new
legacy_threadingtag when the fyneDo migration is explicitly marked as false in FyneApp.tomlChecklist: