Skip to content

Applied Ruff formatting and added kwarg to SimpleTestResourceWrapper … - #22

Draft
riebecj wants to merge 1 commit into
gchq:mainfrom
riebecj:main
Draft

Applied Ruff formatting and added kwarg to SimpleTestResourceWrapper …#22
riebecj wants to merge 1 commit into
gchq:mainfrom
riebecj:main

Conversation

@riebecj

@riebecj riebecj commented Feb 11, 2025

Copy link
Copy Markdown

…to disable debug capture

@CLAassistant

CLAassistant commented Feb 11, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gchqdev227 gchqdev227 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riebecj,

Thank you for opening the PR. It's a bit of a pain, but please could I ask that you undo the ruff formatting you've applied, as it's not a style we're applying across the codebase. I'm aware this isn't mentioned in the contribution guide, so I'll make a note to update that ASAP.

Once that's done I'll take a look at the implementation and run the tests.

@riebecj

riebecj commented Feb 12, 2025

Copy link
Copy Markdown
Author

Hi @riebecj,

Thank you for opening the PR. It's a bit of a pain, but please could I ask that you undo the ruff formatting you've applied, as it's not a style we're applying across the codebase. I'm aware this isn't mentioned in the contribution guide, so I'll make a note to update that ASAP.

Once that's done I'll take a look at the implementation and run the tests.

What format do you use within your code? There doesn't seem to be any apparent code formatting.

@gchqdev227

Copy link
Copy Markdown
Member

@riebecj the pre-commit checks will run flake8 to enforce PEP-8, but other than isort for the imports, it mostly comes down to what is the most readable.

That, and double-quote strings!

@gchqdev227
gchqdev227 marked this pull request as draft March 19, 2025 09:09
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants