Improved cache control #764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the page response caching logic in
PageController.phpto improve cache accuracy and control. The main changes ensure that error pages are never cached, cache headers are generated based on the rendered content, and only cache GET/HEAD requests without query parameters. These improvements help prevent serving outdated or incorrect content.Caching logic improvements:
!$page->isErrorPage()to the$cacheablecondition.ETagandLast-Modified) are now generated using the rendered page content and its last modified time, instead of the content file path, for more accurate cache validation.$page->get('cache.time', null)), allowing for configurable cache durations.Request cacheability refinement:
isRequestCacheable()to require an empty query string.