Preview pages as published #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables previewing unpublished pages as if they were published by temporarily setting the page's published status to true and cacheable to false during preview rendering.
- Stores and restores original page
publishedandcacheablevalues to prevent side effects - Adds explicit
nulldefault parameter tosetValues()for consistent field handling - Uses try-finally block to ensure original values are restored even on exceptions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the preview functionality in the
PagesControllerby ensuring that pages are always rendered as published and non-cacheable during preview, while also preventing unintended side effects by restoring the original page state after rendering. The changes enhance the reliability and correctness of page previews.Preview logic improvements:
publishedandcacheableare restored to the page, preventing any accidental state changes that could affect subsequent operations. [1] [2]Other minor adjustments:
setValueson page fields now includes an explicitnullas the second parameter, clarifying the method invocation.