Skip to content

xterm compat audit: cursor left (CUB) #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2023
Merged

xterm compat audit: cursor left (CUB) #622

merged 5 commits into from
Oct 6, 2023

Conversation

@mitchellh
Copy link
Contributor

This implements full compatibility with xterm for CUB (backspace and CSI D). I found numerous bugs or missing features in our implementation that are now fixed:

  • Implement mode 45 (reverse wrap): cursor left wraps back up a row for soft-wrapped text
  • Implement mode 1045 (extended reverse wrap): cursor left wraps back up for all rows and will wrap around to the bottom of the scroll region once at the top
  • Scroll region awareness, including left/right even though we don't allow changing that yet
  • Test cases for all functionality
@mitchellh mitchellh merged commit 9499dbb into main Oct 6, 2023
@mitchellh mitchellh deleted the xt-cursor-left branch October 6, 2023 16:28
@mitchellh mitchellh mentioned this pull request Oct 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mitchellh