Skip to content

Fix ask-user test snapshots#319

Merged
friggeri merged 1 commit intomainfrom
dev/qmuntal/fixaskuserharness
Feb 2, 2026
Merged

Fix ask-user test snapshots#319
friggeri merged 1 commit intomainfrom
dev/qmuntal/fixaskuserharness

Conversation

@qmuntal
Copy link
Contributor

@qmuntal qmuntal commented Feb 2, 2026

Some ask-user test snapshots no longer match what GitHub Copilot CLI v0.0.400 outputs.

Fixes #315.

@qmuntal qmuntal requested a review from a team as a code owner February 2, 2026 14:16
Copilot AI review requested due to automatic review settings February 2, 2026 14:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ask-user test snapshots so they match the current GitHub Copilot CLI v0.0.400 behavior for freeform ask_user responses, unblocking timeouts in multiple SDK test suites.

Changes:

  • Align freeform tool message content from "User response (freeform): ..." to "User responded: ..." across all ask-user snapshot variants.
  • Add allow_freeform: true to the ask_user tool arguments in the askuser snapshot so all variants model the freeform flow consistently.
  • Normalize the final assistant message in the ask-user freeform snapshot to match the updated conversation wording.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/snapshots/askuser/should_handle_freeform_user_input_response.yaml Updates the tool content to "User responded: ..." and adds allow_freeform: true to match the freeform CLI behavior.
test/snapshots/ask_user/handle_freeform_user_input_response.yaml Updates the tool content string to the new "User responded: ..." format for consistency.
test/snapshots/ask-user/should_handle_freeform_user_input_response.yaml Updates the tool content and the assistant’s final message text to align this snapshot with the current CLI output and other snapshots.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@friggeri friggeri added this pull request to the merge queue Feb 2, 2026
Merged via the queue into main with commit e6e4dec Feb 2, 2026
30 of 31 checks passed
@friggeri friggeri deleted the dev/qmuntal/fixaskuserharness branch February 2, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants