Skip to content

Fix focus and role problems #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
muan merged 7 commits into from
Sep 10, 2019
Merged

Fix focus and role problems #36

muan merged 7 commits into from
Sep 10, 2019

Conversation

@muan
Copy link
Contributor

@muan muan commented Sep 9, 2019

  • Respect [autofocus]:not([role^="menuitem"]) items when menu is toggled

  • Respect existing [role] on <details-menu>

  • Set role="button" on <summary> ref: Quirks with dialog trigger "button"s details-dialog-element#34.

    Per the manner in which the summary element is exposed to Safari's Webkit (announced as "summary" but no matching ARIA role) and Blink (announced as and reported as a "DisclosureTriangle"role) these "buttons" are not discoverable when navigating by form controls or button elements with VoiceOver on macOS or iOS.

  • Remove list markup from demo page– accessibility tree comparison:

before after
image image
@muan muan requested a review from a team September 9, 2019 20:12
dgraham
dgraham approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️
@muan muan merged commit 0651aa2 into master Sep 10, 2019
@muan muan deleted the keyboard branch September 10, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@muan @keithamus @dgraham