Move http client on twirp client build to its own method. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ClientBuilder to move HTTP client configuration into a separate method, making it optional in the constructor. This provides better flexibility for setting up custom HTTP clients with default headers when using direct mode.
- Moved HTTP client parameter from
ClientBuilder::new()to a separatewith_http_client()method - Changed the internal
http_clientfield toOption<reqwest::Client>to defer client creation - Updated the
build()method to create a default client when none is provided
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| self | ||
| } | ||
|
|
||
| /// Set the HTTP client. Without this a default HTTP client is used. |
There was a problem hiding this comment.
Corrected spelling of 'it's' to 'its' in the commit title. The word 'its' is possessive and doesn't need an apostrophe.
This is helpful because there are times you need to set the http client when in direct mode. E.g. you want to preload a load of default headers.
itsibitzi
force-pushed
the
itsibitzi/20251013-builder-http-client
branch
from
ebfc2fb to
2ace17b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful because there are times you need to set the http client when in direct mode. E.g. you want to preload a load of default headers.
Changed the
ClientBuilder::newto no longer take the http client, they can use the method if they need it. This is a minor breaking change but should be easy to port.Uses
Option<Client>in the build because building a HTTP client is non-trivial so it's nicer to not do it twice in the case where you want to use a custom client.